Skip to content

fix(ci): avoid redundant heavy queue benches#24468

Closed
AztecBot wants to merge 1 commit into
merge-train/spartan-v5from
cb/spartan-v5-skip-redundant-inline-benches
Closed

fix(ci): avoid redundant heavy queue benches#24468
AztecBot wants to merge 1 commit into
merge-train/spartan-v5from
cb/spartan-v5-skip-redundant-inline-benches

Conversation

@AztecBot

@AztecBot AztecBot commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Related: AztecProtocol/aztec-packages#24454

Summary

  • pass BENCH_UPLOAD=0 to every non-primary multi_job_run shard
  • make ci-full and ci-full-no-test-cache skip the post-test bench when BENCH_UPLOAD=0
  • keep ordinary single-shard full CI benchmarking unchanged via the default BENCH_UPLOAD=1

Investigation

The dequeued merge-group run did not fail from a merge conflict. PR #24454 is mergeable and its head CI passed. The failed merge-group run had tests complete successfully on the failing full shards, then both ci/x7-full and ci/x9-full entered bench all before being marked failed. The later merge-group run similarly had all observed full shards pass tests, with a remaining shard still spending time in bench all.

This change keeps one benchmark artifact producer and removes the redundant post-test benchmark sweeps from the other heavy queue shards.

Testing

  • bash -n ci.sh && bash -n bootstrap.sh && git diff --check
  • BENCH_UPLOAD=0 gate check: bench_if_enabled skips, while the default path calls bench
  • attempted ./bootstrap.sh ci, but this ref does not define a ci target and exits with Unknown command: ci
  • shellcheck ci.sh bootstrap.sh unavailable: shellcheck is not installed in this container

Created by claudebox · group: slackbot

@AztecBot AztecBot added ci-draft Run CI on draft PRs. ci-full-no-test-cache ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR. labels Jul 2, 2026
@AztecBot

AztecBot commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed.

@AztecBot AztecBot closed this Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. ci-full-no-test-cache ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant